Added more builder methods #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntatic sugar for when the client knows the desired security context type.
rjrudin
commented
Jan 24, 2023
| isML11OrHigher = version.getMajor() >= 11; | ||
|
|
||
| client = newDatabaseClientBuilder().build(); | ||
| schemasClient = newClientForDatabase("java-functest-schemas"); |
Contributor
Author
There was a problem hiding this comment.
newClientForDatabase was only used in 2 places, which doesn't seem like justification enough for a helper method since it barely saves on any code.
Contributor
There was a problem hiding this comment.
Would it be useful to the users of the client?
Contributor
Author
There was a problem hiding this comment.
newClientForDatabase was in src/test/java. I'm trying to slim down ConnectedRestQA as much as possible so it's easier to comprehend. So if there's a helper method only used in one or two places that doesn't help much at all, I'm removing those. No impact on Java Client users.
BillFarber
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntatic sugar for when the client knows the desired security context type.