Enhancements for connecting to ML Cloud #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
force-pushed
the
feature/cloud-reverse-proxy
branch
from
b16971a to
f555016
Compare
These fixes are driven by testing against the ReverseProxyServer which can now emulate ML Cloud. The fixes: 1. If user chooses an sslProtocol of "default", then the JVM's default trust manager will be used as well. 2. If the user uses `withMarkLogicCloudAuth`, then the SSL protocol will default to "default". 3. The call to "/token" in ML Cloud now uses the user-provided SSL hostname verifier (this was not required on the ML Cloud instance I tested with, but that is not guaranteed to be true).
rjrudin
force-pushed
the
feature/cloud-reverse-proxy
branch
from
f555016 to
ddcd6fc
Compare
anu3990
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes are driven by testing against the ReverseProxyServer which can now emulate ML Cloud. The fixes:
withMarkLogicCloudAuth, then the SSL protocol will default to "default".