DEVEXP-563 Added support for other 11.1 Optic methods #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was able to code-generate for the document format/root/permission queries, but DBQ-643 in the server prevents them from working. joinDocAndUri appears to be good-to-go. I had to manually add the string constructors for cts.point and cts.polygon as the code generator does not yet generate those. Added comments to capture that fact. Finally, renamed the two XML TDEs that were using .tdex as an extension - .xml is preferred.
BillFarber
approved these changes
Oct 25, 2023
Contributor
BillFarber
left a comment
BillFarber
left a comment
There was a problem hiding this comment.
LGTM - but I'm flying blind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to code-generate for the document format/root/permission queries, but DBQ-643 in the server prevents them from working.
joinDocAndUri appears to be good-to-go.
I had to manually add the string constructors for cts.point and cts.polygon as the code generator does not yet generate those. Added comments to capture that fact.
Finally, renamed the two XML TDEs that were using .tdex as an extension - .xml is preferred.