Skip to content

MLE-24505 Fixing publishing for the dev tools plugin #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+7 −8
Merged

MLE-24505 Fixing publishing for the dev tools plugin #1835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ml-development-tools/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

/*
* Copyright (c) 2010-2025 Progress Software Corporation and/or its subsidiaries or affiliates. All Rights Reserved.
*/

import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
id "groovy"
id 'maven-publish'
Expand All @@ -18,7 +18,11 @@ dependencies {
// This is a runtime dependency of marklogic-client-api but is needed for compiling.
compileOnly "jakarta.xml.bind:jakarta.xml.bind-api:4.0.4"

implementation project(':marklogic-client-api')
// Gradle 9 does not like for a plugin to have a project dependency; trying to publish it results in a
// NoSuchMethodError pertaining to getProjectDependency. So treating this as a 3rd party dependency. This creates
// additional work during development, though we rarely modify the code in this plugin anymore.
implementation "com.marklogic:marklogic-client-api:${version}"
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ${version} for the marklogic-client-api dependency may cause version mismatches. Consider using a specific version string or a dedicated variable like ${marklogicClientApiVersion} to ensure the correct version is used, especially since this is now treated as a third-party dependency.

Copilot uses AI. Check for mistakes.

implementation 'org.jetbrains.kotlin:kotlin-stdlib:2.1.0'
implementation "com.fasterxml.jackson.module:jackson-module-kotlin:${jacksonVersion}"
implementation 'com.networknt:json-schema-validator:1.0.88'
Expand Down Expand Up @@ -58,11 +62,6 @@ gradlePlugin {
}

publishing {
publications {
mainJava(MavenPublication) {
from components.java
}
}
repositories {
maven {
if (project.hasProperty("mavenUser")) {
Expand Down