Skip to content

MLE-24505 Doing full build on PR pipeline #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

MLE-24505 Doing full build on PR pipeline #1837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ def runTests(String image) {
export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR
export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH
cd java-client-api
// Ensure all modules can be built first.
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line appears inside a shell (sh) multiline string; // is not a valid Bash comment and will be interpreted as a command (likely causing a command not found error). Replace with a Bash comment (# ...) or move the remark outside the shell string as a Groovy comment.

Suggested change
// Ensure all modules can be built first.
# Ensure all modules can be built first.

Copilot uses AI. Check for mistakes.
./gradlew clean build -x test
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invoking clean build -x test forces a full rebuild, then later running marklogic-client-api:test will re-execute tasks that could have been up-to-date; consider using assemble (or a narrower aggregation task) instead of build, and avoid clean unless required for correctness to reduce build time.

Suggested change
./gradlew clean build -x test
./gradlew assemble

Copilot uses AI. Check for mistakes.
mkdir -p marklogic-client-api/build/test-results/test
./gradlew marklogic-client-api:test || true
'''
Expand Down Expand Up @@ -172,6 +174,8 @@ pipeline{
export GRADLE_USER_HOME=$WORKSPACE/$GRADLE_DIR
export PATH=$GRADLE_USER_HOME:$JAVA_HOME/bin:$PATH
cd java-client-api
// Ensure all modules can be built first.
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as earlier occurrence: // inside a shell script block is not a valid Bash comment and will be executed as a command. Use a Bash comment (# Ensure all modules...) or place the comment outside the sh string.

Suggested change
// Ensure all modules can be built first.
# Ensure all modules can be built first.

Copilot uses AI. Check for mistakes.
./gradlew clean build -x test
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate full clean build sequence as above may add unnecessary build time; consider replacing with ./gradlew assemble (or specific compile/package tasks) and omit clean unless a known incremental build issue exists.

Suggested change
./gradlew clean build -x test
./gradlew assemble

Copilot uses AI. Check for mistakes.
./gradlew cleanTest marklogic-client-api:test
'''
// Omitting this until MLE-24523 can be addressed
Expand Down