MLE-24579 Fixed PR test stage #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CI/CD pipeline issue where the test stage would fail the entire pipeline if tests failed, by adding || true to allow the stage to complete even with test failures. The file has also been reformatted for better readability.
- Added
|| trueto the test command to prevent pipeline failure on test failures - Reformatted Jenkinsfile with improved spacing and indentation
- Added explanatory comment for the test execution
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Jenkinsfile
Outdated
| ./gradlew clean build -x test | ||
| ./gradlew cleanTest marklogic-client-api:test | ||
| // Run a sufficient number of tests to verify the PR. |
There was a problem hiding this comment.
Inconsistent indentation: this line uses tabs while the surrounding lines use spaces. Consider using consistent whitespace throughout the file.
Suggested change
| // Run a sufficient number of tests to verify the PR. | |
| // Run a sufficient number of tests to verify the PR. |
Also formatted the file so it's pretty. Only functional change though is on line 181, which ensures that the stage still completes even if tests fail.
rjrudin
force-pushed
the
feature/jenkins-fix
branch
from
e82e9a8 to
5f5cb31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also formatted the file so it's pretty. Only functional change though is on line 181, which ensures that the stage still completes even if tests fail.