Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jan 16, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 16, 2026 19:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds validation for JSON Pointer and XPath exclusion expressions in the IncrementalWriteFilter, ensuring that invalid expressions are caught at build time rather than during document processing. The changes include comprehensive test coverage for both valid and invalid exclusion scenarios.

Changes:

  • Added validation methods for JSON Pointer and XPath expressions in the IncrementalWriteFilter.Builder
  • Created a new test class to verify that invalid exclusion expressions trigger appropriate errors
  • Added test coverage for cross-format exclusion handling (JSON exclusions applied to XML documents)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
IncrementalWriteFilter.java Implements validation logic for JSON Pointer and XPath expressions in the builder's build() method
ApplyInvalidExclusionsToIncrementalWriteTest.java New test class containing unhappy path tests for invalid JSON Pointer and XPath expressions
ApplyExclusionsToIncrementalWriteTest.java Adds test to verify JSON exclusions are correctly ignored when processing XML documents

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Copyright Validation Results
Total: 3 | Passed: 3 | Failed: 0 | Skipped: 0 | at: 2026-01-16 20:23:23 UTC | commit: 617cda7

✅ Valid Files

  • marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
  • marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/ApplyExclusionsToIncrementalWriteTest.java
  • marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/ApplyInvalidExclusionsToIncrementalWriteTest.java

✅ All files have valid copyright headers!

And a couple tests for JSON canonicalization
@rjrudin rjrudin force-pushed the feature/26427-more-exclusions branch from e66f3d2 to 617cda7 Compare January 16, 2026 20:23
@rjrudin rjrudin merged commit e609381 into develop Jan 16, 2026
4 checks passed
@rjrudin rjrudin deleted the feature/26427-more-exclusions branch January 16, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants