MLE-27841 Bumping dependencies before 8.1 release#1917
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR bumps several Gradle-managed dependencies in preparation for the 8.1 release and centralizes Logback versioning via gradle.properties.
Changes:
- Upgrade core dependencies across modules (Undertow, JAXB API, Kotlin stdlib, Jackson, Mockito, commons-lang3).
- Replace hard-coded Logback versions with a shared
logbackVersionproperty. - Move marklogic-junit5 from a snapshot to the 2.0.0 release.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test-app/build.gradle |
Bumps Undertow and switches Logback to ${logbackVersion}. |
ml-development-tools/build.gradle |
Updates JAXB API and Kotlin stdlib versions. |
marklogic-client-api/build.gradle |
Updates JAXB API, hashing lib, marklogic-junit5, Mockito; switches Logback to ${logbackVersion}. |
marklogic-client-api-functionaltests/build.gradle |
Updates JAXB API and switches Logback to ${logbackVersion}. |
gradle.properties |
Bumps Jackson/JUnit versions and introduces logbackVersion. |
examples/build.gradle |
Updates JAXB API and commons-lang3 version; removes file header comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dependencies { | ||
| implementation project(':marklogic-client-api') |
There was a problem hiding this comment.
The examples build file no longer includes the standard copyright header that is present in other Gradle build files in this repo (e.g., root build.gradle, marklogic-client-api/build.gradle). If this wasn’t intentional, please restore the header for consistency and to avoid potential licensing/compliance problems.
| exclude module: "commons-beanutils" | ||
| } | ||
| api 'org.apache.commons:commons-lang3:3.19.0' | ||
| api 'org.apache.commons:commons-lang3:3.20.0' |
There was a problem hiding this comment.
This module now declares commons-lang3 3.20.0, but the root build.gradle forces commons-lang3 to 3.19.0 via resolutionStrategy.force. As a result, this version bump likely won’t take effect; consider updating/removing the forced version so the intended dependency version is actually used.
| api 'org.apache.commons:commons-lang3:3.20.0' | |
| api 'org.apache.commons:commons-lang3:3.19.0' |
| implementation "com.marklogic:marklogic-client-api:${version}" | ||
|
|
||
| implementation 'org.jetbrains.kotlin:kotlin-stdlib:2.2.20' | ||
| implementation 'org.jetbrains.kotlin:kotlin-stdlib:2.2.21' |
There was a problem hiding this comment.
kotlin-stdlib is bumped to 2.2.21 while the applied Kotlin Gradle plugin is 2.1.0. Mixing Kotlin plugin and stdlib major/minor versions can cause ABI/runtime issues; consider aligning the stdlib version with the plugin version (or removing the explicit stdlib dependency and letting the plugin manage it).
| implementation 'org.jetbrains.kotlin:kotlin-stdlib:2.2.21' | |
| implementation 'org.jetbrains.kotlin:kotlin-stdlib:2.1.0' |
| testImplementation "org.mockito:mockito-core:5.21.0" | ||
| testImplementation "org.mockito:mockito-inline:5.2.0" | ||
| testImplementation "org.mockito:mockito-core:5.22.0" | ||
| // testImplementation "org.mockito:mockito-inline:5.2.0" |
There was a problem hiding this comment.
mockito-inline was commented out but left in the dependencies block (and it’s pinned to 5.2.0 while mockito-core is 5.22.0). This is easy to miss and can cause confusion or accidental re-enablement with incompatible versions; either remove it entirely or re-enable it with a matching version and an explanatory comment for why it’s needed.
| // testImplementation "org.mockito:mockito-inline:5.2.0" |
Added a few "since" annotations as well.
rjrudin
force-pushed
the
feature/27481-bumps
branch
from
8296245 to
86f9223
Compare
No description provided.