MLE-28583 ML12 test fixes#1940
Merged
Merged
Conversation
Ignore tests that are no longer supported in ML12. Getting the user a different way since xdmp calls have been restricted.
There was a problem hiding this comment.
Pull request overview
This PR updates the Java client API test suite to account for MarkLogic 12 behavior changes—specifically, functions removed in ML12 (xdmp.uriContentType, xdmp.uriFormat, xdmp.getCurrentUser)—so that tests either skip appropriately on ML12 or no longer depend on removed server APIs.
Changes:
- Reworked
UpdateUseCasesTest.wrapContentInEnvelopeto avoidxdmp.getCurrentUser()by binding the expected username as a plan parameter. - Disabled generated Optic tests that call removed
xdmp.*functions by gating them withRequiresML11OrLower. - Centralized the test username in
AbstractOpticUpdateTestvia a shared constant.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marklogic-client-api/src/test/java/com/marklogic/client/test/rows/UpdateUseCasesTest.java |
Avoids xdmp.getCurrentUser() by binding currentUser as a parameter and asserting against TEST_USER. |
marklogic-client-api/src/test/java/com/marklogic/client/test/rows/AbstractOpticUpdateTest.java |
Introduces TEST_USER constant and reuses it in test client setup. |
marklogic-client-api/src/test/java/com/marklogic/client/test/PlanGeneratedTest.java |
Skips tests that depend on removed ML12 xdmp.* functions using @ExtendWith(RequiresML11OrLower.class). |
RitaChen609
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xdmp.uriContentType and xdmp.uriFormat are no longer available in 12, the tests should only be run in 11 or lower.
Fixed how we get the user in marklogic-client-api/src/test/java/com/marklogic/client/test/rows/UpdateUseCasesTest.java as xdmp.getCurrentUser is no longer available.