Skip to content

Conversation

@nikos
Copy link
Contributor

@nikos nikos commented Aug 13, 2014

...o logback a bit.

@nikos nikos mentioned this pull request Aug 13, 2014
@sammefford
Copy link
Contributor

Thanks, Niko, for the contribution. We love that you submitted it as a pull request. To do things right for this and future pull requests, we are finalizing a CLA (Contributor License Agreement), and will be in touch with regard to your pull request as soon as the CLA is ready to go.

@nikos
Copy link
Contributor Author

nikos commented Aug 25, 2014

Great to hear back from you, Sam.

Just for reference, if you are interested you can have a look into the pom.xml (line 48 is the logback exclusion to avoid the version conflict) from a my springboot-marklogic-sample project.

@sammefford
Copy link
Contributor

Makes sense. Good work-around. When we get this integrated you won't need that, correct?

@nikos
Copy link
Contributor Author

nikos commented Aug 25, 2014

Exactly.

Please be aware that I am using MarkLogic 7, and therefore would like to propose to get thelogback update also merged into your b2_0 branch. Thanks.

@sammefford
Copy link
Contributor

Niko, b2_0 is compatible with MarkLogic 7. If you're using MarkLogic 8, can you help me understand why you would like the logback update also on the b2_0 branch?

@nikos
Copy link
Contributor Author

nikos commented Aug 25, 2014

@sammefford sorry, I was dreaming, in reality I have to stick with ML 7 right now :)

@sammefford
Copy link
Contributor

Ok, Niko, thanks for the CLA so I can merge any future pull requests. I've made this change on the dev and b2_0 branches.

@sammefford sammefford closed this Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants