update to CloudFormation templates and instructions #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating the AWS quickstart document. * Updating the AWS quickstart document. (#19) * Can now run a flow using DHF 5.2.0 (#21) The key changes are in MarkLogicSinkTask and RunFlowWriteBatchListener. See the comments in those classes for the changes. There are 3 new properties for using this - a DHF flow name, and optional set of steps, and an option for logging each flow response. If the flow name is set, then that flow will be run. Otherwise, only the regular ingestion happens. I had to make one plumbing change - DatabaseClientCreator is now DatabaseClientConfigBuilder, as I needed to reuse the DatabaseClientConfig object. That's a small plumbing change though that could be made independently of this change. Co-authored-by: Rob Rudin <rob.rudin@marklogic.com> * Updating the AWS quickstart document. (#23) Co-authored-by: rjrudin <rjrudin@gmail.com> Co-authored-by: Rob Rudin <rob.rudin@marklogic.com>
Can now run a flow using DHF 5.2.0 (#24)
…dded some steps to CloudFormation-QuickStart.md
|
Like the PR for running a flow, I recommend targeting this to the develop branch. Get everything together on that branch, then do a single merge commit to master (or rebase master on top of develop) and publish a release. Master should always reflect the latest release. |
BillFarber
added a commit
that referenced
this pull request
May 24, 2020
* Incremented the minor version in the develop branch for new work. * update to CloudFormation templates and instructions (#25) * Can now run a flow using DHF 5.2.0 The key changes are in MarkLogicSinkTask and RunFlowWriteBatchListener. See the comments in those classes for the changes. There are 3 new properties for using this - a DHF flow name, and optional set of steps, and an option for logging each flow response. If the flow name is set, then that flow will be run. Otherwise, only the regular ingestion happens. I had to make one plumbing change - DatabaseClientCreator is now DatabaseClientConfigBuilder, as I needed to reuse the DatabaseClientConfig object. That's a small plumbing change though that could be made independently of this change. Co-authored-by: Rob Rudin <rob.rudin@marklogic.com> * Updating the AWS quickstart document. * Update AWS-CloudFormation/cloudFormationTemplates/* with newer AMI, added some steps to CloudFormation-QuickStart.md Co-authored-by: Stuart Moorhouse <Stuart.Moorhouse@marklogic.com> * Removing some erroneous comments in the example connect-standalone properties file. (#28) Co-authored-by: sMoorhouse <stuartmoorhouse@rocketmail.com> Co-authored-by: Stuart Moorhouse <Stuart.Moorhouse@marklogic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated AWS-CloudFormation/cloudFormationTemplates/* with newer AMI and added some steps to CloudFormation-QuickStart.md