Skip to content

MLE-11464: Implementation for Securing MarkLogic Group deployment #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 23, 2024
Merged

MLE-11464: Implementation for Securing MarkLogic Group deployment #12

merged 9 commits into from
Aug 23, 2024

Conversation

@barkhachoithani
Copy link
Collaborator

@barkhachoithani barkhachoithani commented Aug 12, 2024

No description provided.

rwinieski
rwinieski requested changes Aug 12, 2024
View reviewed changes
pengzhouml
pengzhouml requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@pengzhouml pengzhouml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR only have logic for MarklogicServer, which is actually for MarkLogicCluster. I don't see the reconcile logic for MarkLogicGroup.

@barkhachoithani barkhachoithani marked this pull request as draft August 13, 2024 15:50
@barkhachoithani
Copy link
Collaborator Author

barkhachoithani commented Aug 13, 2024

The PR only have logic for MarklogicServer, which is actually for MarkLogicCluster. I don't see the reconcile logic for MarkLogicGroup.

Updated the implementation for MarkLogic Group

@barkhachoithani barkhachoithani marked this pull request as ready for review August 13, 2024 20:59
@rwinieski rwinieski requested a review from pengzhouml August 14, 2024 09:05
pengzhouml
pengzhouml approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@pengzhouml pengzhouml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for networkPolicy that missing, other looks good to me.
Sicne we merged main to develop, you might need to resolve conflict before merging.

@barkhachoithani
Copy link
Collaborator Author

barkhachoithani commented Aug 16, 2024

Except for networkPolicy that missing, other looks good to me. Sicne we merged main to develop, you might need to resolve conflict before merging.

NetworkPolicy will be taken care in separate story. Rebased feature branch with develop.

rwinieski
rwinieski requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@rwinieski rwinieski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all variables that are int values, we should use const and not var ?

@barkhachoithani barkhachoithani merged commit 142d1a2 into marklogic:develop Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwinieski rwinieski rwinieski approved these changes

@vitalykorolev vitalykorolev Awaiting requested review from vitalykorolev

@sumanthravipati sumanthravipati Awaiting requested review from sumanthravipati

@pengzhouml pengzhouml Awaiting requested review from pengzhouml

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barkhachoithani @rwinieski @pengzhouml