DEVEXP-498 Can now define default metadata #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized my initial "DocumentBatch" design was not good because it limited the user to defining a single set of default metadata. And the v1/documents endpoint allows for many sets of default metadata. The new design - introducing a DefaultMetadata class, and allowing the user to provide a list of any number of Document and DefaultMetadata instances - is simpler and adheres to what /v1/documents allows too. No docs yet. Going to do a separate PR for those next.
anu3990
approved these changes
Jul 14, 2023
BillFarber
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized my initial "DocumentBatch" design was not good because it limited the user to defining a single set of default metadata. And the v1/documents endpoint allows for many sets of default metadata. The new design - introducing a DefaultMetadata class, and allowing the user to provide a list of any number of Document and DefaultMetadata instances - is simpler and adheres to what /v1/documents allows too.
No docs yet. Going to do a separate PR for those next.