DEVEXP-503 Can now read a batch of documents with metadata #12
Conversation
rjrudin
force-pushed
the
feature/503-read-docs
branch
from
ebc62c0 to
30e2ebf
Compare
| URI. By default, only content will be returned for each URI. See the endpoint | ||
| documentation for further information. | ||
| """ | ||
| response = self._get_multipart_documents_response(uris, categories, **kwargs) |
There was a problem hiding this comment.
Would it be helpful if to return the response code if the URI isn't found?
What if there's a network or authentication error?
With Python, is it generally assumed that the user of these functions will do their own error handling?
There was a problem hiding this comment.
Good point. I'll add a test user that lacks the "rest-reader" role and thus will get a 4xx, and I'll add a test to verify that it's returned.
So I think that will change the method signature to return either a list[Document] or a Response.
There was a problem hiding this comment.
No longer need this now that we have a real "read" capability.
| URI. By default, only content will be returned for each URI. See the endpoint | ||
| documentation for further information. | ||
| """ | ||
| response = self._get_multipart_documents_response(uris, categories, **kwargs) |
There was a problem hiding this comment.
Good point. I'll add a test user that lacks the "rest-reader" role and thus will get a 4xx, and I'll add a test to verify that it's returned.
So I think that will change the method signature to return either a list[Document] or a Response.
Reworked some of the existing "write" tests to now use `client.documents.read` to verify data that was written.
rjrudin
force-pushed
the
feature/503-read-docs
branch
from
30e2ebf to
305de78
Compare
| assert {"hello": "world"} == doc.content | ||
|
|
||
|
|
||
| def test_not_rest_user(not_rest_user_client: Client): |
There was a problem hiding this comment.
@BillFarber Added this test for a non-200 response.
Reworked some of the existing "write" tests to now use
client.documents.readto verify data that was written.