DEVEXP-575: Submit GraphQL query with Python client #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
requested changes
Sep 20, 2023
BillFarber
force-pushed
the
feature/submitGraphql
branch
2 times, most recently
from
6cfb9f2 to
9fe0467
Compare
rjrudin
approved these changes
Sep 20, 2023
Contributor
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
Looks good, just rename Rows to RowManager and then up to you if you want to simplify the "is this in the list" assertions.
BillFarber
force-pushed
the
feature/submitGraphql
branch
from
9fe0467 to
6419014
Compare
BillFarber
force-pushed
the
feature/submitGraphql
branch
from
6419014 to
8424b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I didn't do, but maybe should have: change the tests that use the "test-data" collection for searching, etc. My thought is that we use a different collection for searching and put the "test-data" collection on all data.