Moved eval guts into impl/eval.py #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reworked `client.eval` so it accepts args for the scripts. The thought behind `impl` is that since everything is public in Python, "impl" gives us a way of communicating that whatever is in here isn't intended to be used by a user. So out modules not in "impl" can access stuff in "impl", but users should not.
BillFarber
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reworked
client.evalso it accepts args for the scripts.The thought behind
implis that since everything is public in Python, "impl" gives us a way of communicating that whatever is in here isn't intended to be used by a user. So out modules not in "impl" can access stuff in "impl", but users should not.