DEVEXP-494 Can now connect to MarkLogic Cloud #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillFarber
reviewed
Jul 11, 2023
| data={"grant_type": "apikey", "key": api_key}, | ||
| verify=self._verify, | ||
| ) | ||
| self._access_token = response.json()["access_token"] |
Contributor
There was a problem hiding this comment.
Do you need any error handling here?
Contributor
Author
There was a problem hiding this comment.
Good point, I forget if a 4xx gets thrown right away - I'll add a test case for it.
BillFarber
approved these changes
Jul 11, 2023
rjrudin
force-pushed
the
feature/494-cloud
branch
from
bca7446 to
05e9284
Compare
BillFarber
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.