This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Feature/issue 28 add temporal config #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 3, 2017 16:27
… feature/issue-28-add-temporal-config # Conflicts: # src/main/java/com/marklogic/appdeployer/command/SortOrderConstants.java
rjrudin
commented
Mar 19, 2017
| private String databaseIdOrName; | ||
|
|
||
| public DeployTemporalAxesCommand() { | ||
| // TODO - verify that range element indexes exist before creation of temporal axes? |
Contributor
Author
There was a problem hiding this comment.
I think this is fine - possible enhancement in the future if the Manage API doesn't give a very helpful error
rjrudin
commented
Mar 19, 2017
| public DeployTemporalCollectionsCommand() { | ||
| setExecuteSortOrder(SortOrderConstants.DEPLOY_TEMPORAL_COLLECTIONS); | ||
| // if the temporal collection contains documents, then the delete operation will fail | ||
| // TODO - could add check to get count of documents in temporal collection. If zero docs, then can delete |
Contributor
Author
There was a problem hiding this comment.
I think this is fine too. "Undeploying" temporal config can be a future enhancement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.