Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 21, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 21, 2025 17:29
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Copyright Validation Results
Total: 3 | Passed: 0 | Failed: 0 | Skipped: 3 | at: 2025-10-23 17:46:52 UTC | commit: dc34ab8

⏭️ Skipped (Excluded) Files

  • .gitignore
  • Jenkinsfile
  • test-app/build.gradle

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces a hardcoded sleep timer with MarkLogic's mlWaitTillReady task for improved reliability when waiting for MarkLogic to be ready. The changes upgrade ml-gradle to version 6.2-SNAPSHOT to utilize this new task.

  • Upgraded ml-gradle from version 5.0.0 to 6.2-SNAPSHOT
  • Configured mlWaitTillReady task to wait for MarkLogic availability
  • Replaced 90-second sleep with mlWaitTillReady task invocation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
test-app/build.gradle Upgraded ml-gradle to 6.2-SNAPSHOT and configured mlWaitTillReady task with default polling intervals
Jenkinsfile Replaced hardcoded 90s sleep with mlWaitTillReady task execution before deployment steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

buildscript {
repositories {
mavenCentral()
// Needed for ml-gradle 6.2-SNAPSHOT mavenLocal()
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing and formatting issue: the comment has inconsistent whitespace with 'mavenLocal()' appearing on the same line instead of the next line.

Suggested change
// Needed for ml-gradle 6.2-SNAPSHOT mavenLocal()
// Needed for ml-gradle 6.2-SNAPSHOT
mavenLocal()

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin force-pushed the feature/24763-wait branch 3 times, most recently from 3fbcd15 to e5a493b Compare October 22, 2025 13:08
@rjrudin rjrudin force-pushed the feature/24763-wait branch from e5a493b to dc34ab8 Compare October 23, 2025 17:46
@rjrudin rjrudin merged commit 7baddea into develop Oct 23, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/24763-wait branch October 23, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants