Skip to content

Conversation

@BillFarber
Copy link
Contributor

Very close.
My most recent local run only had a single failing test.

My most recent run only had a single failing test.
@BillFarber BillFarber requested a review from anu3990 as a code owner October 22, 2025 03:20
@BillFarber BillFarber requested a review from anu3990 October 22, 2025 03:20
@BillFarber BillFarber requested a review from rjrudin as a code owner October 22, 2025 03:20
@BillFarber BillFarber requested review from Copilot and rjrudin October 22, 2025 03:20
@BillFarber BillFarber requested a review from stevebio as a code owner October 22, 2025 03:20
@BillFarber BillFarber requested a review from stevebio October 22, 2025 03:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up temporal document management and LSQT (Last Stable Query Time) configuration for the MarkLogic test application. The changes configure temporal axes, collections, security roles, and necessary database indexes to support bi-temporal document tracking.

  • Adds temporal axis definitions for system time and valid time tracking
  • Creates temporal collections and associated security roles with required privileges
  • Configures database indexes required for temporal operations

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rest-temporal-writer.json Defines new security role with temporal privileges for document operations
nodeOpticFunctionalTest.json Enables triple-index and collection-lexicon for the test database
temporalCollectionLsqt.json Creates LSQT temporal collection configuration
temporal-collection.json Creates standard temporal collection configuration
temporal-valid-axis.json Defines valid time axis with start/end element references
temporal-system-axis.json Defines system time axis with start/end element references
node-client-api-rest-server.json Adds range element indexes for temporal fields and an amt field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Copyright Validation Results
Total: 9 | Passed: 0 | Failed: 0 | Skipped: 9 | at: 2025-10-22 03:21:17 UTC | commit: 078d348

⏭️ Skipped (Excluded) Files

  • .gitignore
  • test-complete-app-mlDeploy/src/main/ml-config/databases/node-client-api-rest-server.json
  • test-complete-app-mlDeploy/src/main/ml-config/databases/node-client-api-rest-server/temporal/axes/temporal-system-axis.json
  • test-complete-app-mlDeploy/src/main/ml-config/databases/node-client-api-rest-server/temporal/axes/temporal-valid-axis.json
  • test-complete-app-mlDeploy/src/main/ml-config/databases/node-client-api-rest-server/temporal/collections/temporal-collection.json
  • test-complete-app-mlDeploy/src/main/ml-config/databases/node-client-api-rest-server/temporal/collections/temporalCollectionLsqt.json
  • test-complete-app-mlDeploy/src/main/ml-config/databases/nodeOpticFunctionalTest.json
  • test-complete-app-mlDeploy/src/main/ml-config/security/roles/rest-temporal-writer.json
  • test-complete-app-mlDeploy/src/main/ml-config/security/users/rest-temporal-writer.json

✅ All files have valid copyright headers!

@BillFarber BillFarber merged commit db72abe into marklogic:develop Oct 22, 2025
2 of 3 checks passed
@BillFarber BillFarber deleted the startingTemporal branch October 22, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants