Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 29, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 29, 2025 15:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused data files from the etc/data/ directory as part of cleanup efforts. The removal includes various test data files across different formats (XML, JSON, XSLT, JavaScript, and template definition files) that are no longer needed in the codebase.

  • Removes multiple test data files including XML documents, JSON schemas, XSLT stylesheets, and template definition files
  • Updates a comment reference in the test file to reflect the removal of the employees.tdej file
  • Cleans up validation, transformation, and template files that were previously used for testing

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test-basic/rows.js Removes outdated comment referencing deleted employees.tdej file
etc/data/validateDoc-test.sch-validator.xsl Deletes XSLT validator file for document validation tests
etc/data/validateDoc-test.sch Removes Schematron schema file for validation testing
etc/data/validateDoc-test.json Deletes JSON schema file used for validation tests
etc/data/unnestView.tdej Removes template definition file for unnest view operations
etc/data/tripleSets.xml Deletes XML file containing semantic triple sets for testing
etc/data/transformDoc-test.xslt Removes XSLT transformation file for document testing
etc/data/transformDoc-test.mjs Deletes JavaScript module for document transformation tests
etc/data/transformDoc-test-two-params.mjs Removes JavaScript module with two-parameter transformation
etc/data/rowPostProcessors.sjs Deletes server-side JavaScript file for row post-processing
etc/data/musician.tdex Removes XML template definition for musician data
etc/data/masterDetail.xml Deletes XML file containing master-detail test data
etc/data/masterDetail.tdex Removes XML template definition for master-detail views
etc/data/employees.tdej Deletes JSON template definition for employee data
etc/data/articleCitation.json Removes JSON template for article citation data
etc/data/Publisher-2.xml Deletes second publisher XML test data file
etc/data/Publisher-1.xml Removes first publisher XML test data file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Copyright Validation Results
Total: 1 | Passed: 1 | Failed: 0 | Skipped: 0 | at: 2025-10-29 15:07:31 UTC | commit: 150f672

✅ Valid Files

  • test-basic/rows.js

✅ All files have valid copyright headers!

@rjrudin rjrudin merged commit faf7be4 into develop Oct 29, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/more-deletes branch October 29, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants