Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Nov 24, 2025

Also removed the second mlWaitTillReady call based on updates to ml-gradle

Copilot AI review requested due to automatic review settings November 24, 2025 20:11
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Copyright Validation Results
Total: 1 | Passed: 0 | Failed: 0 | Skipped: 1 | at: 2025-11-25 19:15:05 UTC | commit: 91d26d3

⏭️ Skipped (Excluded) Files

  • Jenkinsfile

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR excludes fragile tests from PR builds and simplifies the deployment process by removing a redundant mlWaitTillReady call. The changes target improved build stability by temporarily skipping problematic document data movement tests in PR builds while still running them in other build contexts.

  • Excludes fragile tests (documents-data-movement-*) from PR builds
  • Removes redundant mlWaitTillReady call and sleep
  • Converts shell script from single quotes to double quotes for variable interpolation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Jenkinsfile Outdated
Comment on lines 3 to 5
def runTests(excludeFragileTests = false) {
def mochaGlob = excludeFragileTests ?
'test-basic/!(documents-data-movement-*).js' :
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The excluded test pattern 'documents-data-movement-*' is hardcoded. Consider extracting this to a pipeline parameter or configuration variable to make it easier to maintain and modify the list of excluded tests without code changes.

Suggested change
def runTests(excludeFragileTests = false) {
def mochaGlob = excludeFragileTests ?
'test-basic/!(documents-data-movement-*).js' :
def runTests(excludeFragileTests = false, excludedTestPattern = 'documents-data-movement-*') {
def mochaGlob = excludeFragileTests ?
"test-basic/!(${excludedTestPattern}).js" :

Copilot uses AI. Check for mistakes.
Also removed the second mlWaitTillReady call based on updates to ml-gradle
@rjrudin rjrudin force-pushed the feature/fragile-tests branch from 0be1956 to 91d26d3 Compare November 25, 2025 19:14
@rjrudin rjrudin merged commit 750b8ff into develop Nov 25, 2025
6 checks passed
@rjrudin rjrudin deleted the feature/fragile-tests branch November 25, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants