MLE-23011 : Jenkins test failures #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test failures by updating error handling patterns and adding missing dependencies. The changes primarily focus on improving async error handling in test cases and ensuring proper test assertions.
- Updated error handling from synchronous try-catch to asynchronous catch blocks
- Added missing assert module import for test assertions
- Modified error message validation to match updated API error responses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-complete/nodejs-optic-nodes.js | Updated error handling from callback-only to promise-based with catch block |
| test-basic/fromDocDescriptors-test.js | Added assert import and restructured error handling test with updated error message validation |
Comments suppressed due to low confidence (1)
test-basic/fromDocDescriptors-test.js:138
- The variable name 'error' shadows the outer scope 'error' parameter. Consider renaming the inner catch variable to 'assertError' or 'err' for clarity.
} catch(error){
| } | ||
| db.rows.query(op.fromDocDescriptors('asd')) | ||
| .catch(error => { | ||
| try{ |
There was a problem hiding this comment.
[nitpick] Missing space before opening brace. Should be 'try {' to maintain consistent code formatting.
Suggested change
| try{ | |
| try { |
rjrudin
previously approved these changes
Jul 18, 2025
rjrudin
approved these changes
Jul 21, 2025
anu3990
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.