Remove www-authenticate dependency #962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added custom digest-auth.js module supporting RFC 7616 and RFC 2069 - Removed www-authenticate package dependency - Updated requester.js to use digest-auth.js - Added unit tests that should cover all MarkLogic scenarios
brycebaril
requested review from
BillFarber,
anu3990,
rjrudin and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the www-authenticate package dependency by implementing a custom RFC 7616/2069 compliant digest authentication module. The change reduces external dependencies while maintaining full compatibility with MarkLogic's digest authentication scenarios.
- Replaced
www-authenticatedependency with customdigest-auth.jsimplementation - Added comprehensive unit tests covering RFC 7616, RFC 2069, and MarkLogic-specific scenarios
- Updated authentication flow in
requester.jsto use the new module
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Removed www-authenticate dependency |
| lib/digest-auth.js | Added custom digest authentication implementation |
| lib/requester.js | Updated to use new digest-auth module |
| test-basic/digest-auth-unit-test.js | Added comprehensive unit tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks @brycebaril ! We've got our hands full with a few things right now but will try to review this soon. Thanks for putting together both the issue and the PR. |
|
Thank you for fixing this via other methods! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961