Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 16, 2025

No linting fixes yet. Changing from the older jshint to the modern eslint. The eslint config doesn't enforce whitespace yet, will do that in a later PR.

Copilot AI review requested due to automatic review settings October 16, 2025 16:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project's linting infrastructure from jshint to eslint, introducing modern linting tooling while deferring whitespace/formatting enforcement to a future PR.

Key changes:

  • Upgraded eslint from v8 to v9 with flat config format
  • Replaced jshint with eslint in the gulp build pipeline
  • Created comprehensive eslint configuration with many spacing rules temporarily disabled

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
package.json Updated eslint to v9.37.0, added gulp-eslint-new, removed jshint and gulp-jshint dependencies
gulpfile.js Replaced jshint linting task with eslint, updated file glob pattern to explicitly match .js files
eslint.config.js Added new flat config with rules matching previous jshint settings, spacing/formatting rules disabled for now
.jshintrc Removed legacy jshint configuration file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Copyright Validation Results
Total: 4 | Passed: 2 | Failed: 0 | Skipped: 2 | at: 2025-10-16 16:51:29 UTC | commit: 14576cb

⏭️ Skipped (Excluded) Files

  • package-lock.json
  • package.json

✅ Valid Files

  • eslint.config.js
  • gulpfile.js

✅ All files have valid copyright headers!

No linting fixes yet. Changing from the older jshint to the modern eslint. The eslint config doesn't enforce whitespace yet, will do that in a later PR.
@rjrudin rjrudin force-pushed the feature/24763-lint branch from 6c1a18c to 14576cb Compare October 16, 2025 16:51
@rjrudin rjrudin merged commit f4d3670 into develop Oct 16, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/24763-lint branch October 16, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants