Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 17, 2025

Using .npmrc instead of custom script to cause an error on npm install.

Copilot AI review requested due to automatic review settings October 17, 2025 19:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Node.js version requirement from 16.14 to 22.0 and modernizes the version enforcement mechanism by replacing a custom validation script with npm's built-in engine-strict feature.

Key changes:

  • Removes custom Node.js version checking script in favor of npm's native engine enforcement
  • Updates minimum Node.js version requirement to 22.0.0
  • Bumps package version to 4.0.0 (major version due to breaking change in Node.js requirement)

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Removed preinstall/prestart/pretest hooks for version checking, updated engine requirement to Node 22+, bumped version to 4.0.0
checkNodeVersion.js Deleted custom Node.js version validation script
.npmrc Added engine-strict configuration to enforce Node.js version requirement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

.npmrc Outdated
Comment on lines 1 to 3
{
"engine-strict": true
}
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .npmrc file uses JSON format, but .npmrc files should use INI format (key=value pairs). The correct syntax should be engine-strict=true without braces or quotes.

Suggested change
{
"engine-strict": true
}
engine-strict=true

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Copyright Validation Results
Total: 3 | Passed: 0 | Failed: 0 | Skipped: 3 | at: 2025-10-17 19:09:10 UTC | commit: 92f2ab9

⏭️ Skipped (Excluded) Files

  • .npmrc
  • package-lock.json
  • package.json

✅ All files have valid copyright headers!

Using .npmrc instead of custom script to cause an error on `npm install`.
@rjrudin rjrudin force-pushed the feature/24763-bump-node branch from 92751bb to 92f2ab9 Compare October 17, 2025 19:08
@rjrudin rjrudin merged commit 762f8e9 into develop Oct 20, 2025
2 of 3 checks passed
@rjrudin rjrudin deleted the feature/24763-bump-node branch October 20, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants