Partial matches#117
Merged
benthestatistician merged 1 commit intomarkmfredrickson:masterfrom Jul 20, 2016
JanMarvin:warnPartialMatchDollar
Merged
Partial matches#117benthestatistician merged 1 commit intomarkmfredrickson:masterfrom JanMarvin:warnPartialMatchDollar
benthestatistician merged 1 commit intomarkmfredrickson:masterfrom
JanMarvin:warnPartialMatchDollar
Conversation
These create warnings if used in combination with `options(warnPartialMatchDollar = TRUE)` Since R's default is to not warn this is not of high importance.
Collaborator
|
Looks good to me! Thanks for the suggestion, @JanMarvin . I'm pretty sure I'm the one responsible for this code, in particular for its use of partial matching, so I'm going to go ahead had accept the pull request. Feel free to chime and/or adjust as you see fit, though, @markmfredrickson and @josherrickson . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, without the changes
optmatchcreates warnings if used in combination withoptions(warnPartialMatchDollar = TRUE)Since R's default is to not warn this is not of high importance.