Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes FMSG_JWT_SECRET mandatory for JWT signing/verification and adds support for supplying the secret as base64 (decoded to raw bytes) to avoid relying on an unsafe built-in development fallback.
Changes:
- Remove the hardcoded development JWT signing secret fallback and require
FMSG_JWT_SECRET. - Decode
FMSG_JWT_SECRETfrom base64 when applicable; otherwise use the raw string bytes. - Update README configuration table to reflect that
FMSG_JWT_SECRETis required.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/auth/token.go | Enforces required JWT secret and adds optional base64 decoding before signing/parsing tokens. |
| README.md | Updates documented default for FMSG_JWT_SECRET to required. |
Agent-Logs-Url: https://github.com/markmnl/fmsg-cli/sessions/7a09e602-9661-4863-bb49-fed7eddcae2e Co-authored-by: markmnl <2630321+markmnl@users.noreply.github.com>
Copilot stopped work on behalf of
markmnl due to an error
April 18, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.