Skip to content

Conversation

@LuLaValva
Copy link
Member

Description

  • Ensure that special attributes haven't changed when rerendering; if they have, revert to the state Marko expects.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@LuLaValva LuLaValva self-assigned this Feb 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 2fe43c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (f56fb10) to head (2fe43c3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/runtime-class/src/runtime/vdom/VElement.js 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2528      +/-   ##
==========================================
- Coverage   87.08%   87.08%   -0.01%     
==========================================
  Files         352      352              
  Lines       40493    40492       -1     
  Branches     2693     2693              
==========================================
- Hits        35264    35263       -1     
  Misses       5203     5203              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuLaValva LuLaValva merged commit 136bb14 into main Feb 20, 2025
9 of 10 checks passed
@LuLaValva LuLaValva deleted the special-attr-check branch February 20, 2025 21:54
@github-actions github-actions bot mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants