Skip to content

Conversation

@rturnq
Copy link
Contributor

@rturnq rturnq commented Apr 10, 2025

Description

Prevents error when readable stream from toReadable is cancelled externally

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

🦋 Changeset detected

Latest commit: 993cebb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
marko Patch
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 87.41%. Comparing base (2847b81) to head (993cebb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/html/template.ts 0.00% 12 Missing ⚠️
...ages/runtime-class/src/runtime/html/AsyncStream.js 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
- Coverage   87.44%   87.41%   -0.04%     
==========================================
  Files         360      360              
  Lines       42483    42501      +18     
  Branches     2972     2972              
==========================================
  Hits        37151    37151              
- Misses       5304     5322      +18     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rturnq rturnq merged commit fa702ed into main Apr 10, 2025
8 of 10 checks passed
@rturnq rturnq deleted the cancel-readable branch April 10, 2025 18:15
@github-actions github-actions bot mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants