Skip to content

Conversation

@rturnq
Copy link
Contributor

@rturnq rturnq commented Jan 17, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2026

🦋 Changeset detected

Latest commit: 49283a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

Walkthrough

The PR introduces a bug fix for controllable text inputs when spreading value and valueChange handlers. The core changes update the controllable input handling logic in the runtime, with a corresponding minor bundle size reduction (2 bytes via Brotli compression). The fix includes behavioral adjustments in the _attr_input_value function where the ControlledType assignment is corrected. Comprehensive test fixtures are added for controllable inputs, selects, textareas, and checked values, each with associated test helper functions to simulate user interactions. A changeset entry documents the fix for tracking version updates.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the bug being fixed and why these changes resolve it.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main fix: addressing controllable text input issues when spreading value or valueChange properties.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.03%. Comparing base (f555806) to head (49283a0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
+ Coverage   88.95%   89.03%   +0.08%     
==========================================
  Files         375      375              
  Lines       47379    47379              
  Branches     4080     4085       +5     
==========================================
+ Hits        42145    42183      +38     
+ Misses       5182     5145      -37     
+ Partials       52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rturnq rturnq merged commit 22326da into main Jan 17, 2026
11 checks passed
@rturnq rturnq deleted the fix-controllable-spread branch January 17, 2026 00:18
@github-actions github-actions bot mentioned this pull request Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants