feat(dev-server): Allow overriding host for dev server up#11
Merged
markshust merged 5 commits intomarko-php:developfrom Apr 15, 2026
Merged
Conversation
95a94da to
010ba9d
Compare
- Remove -h short flag for host (conflicts with --help convention) - Add input validation to prevent command injection via --host - Add test for --host long option override - Add test for invalid host rejection - Revert unrelated style changes (fn spacing, anonymous class spacing) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Thanks for the contribution @renanmedina and @artmuscode! Pushed some follow-up fixes directly to the branch:
All 129 dev-server tests pass, lint is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostoption todev:upcommand for devcontainer/Codespaces support--hostCLI option, then falls back todev.hostconfig (default:localhost)-hwas removed to avoid conflict with--help)Related Issues
Closes #9
Checklist
./vendor/bin/pest packages/dev-server/tests)./vendor/bin/phpcs)