docs: expand PR review process with package-PR checklist#46
Merged
Conversation
…licy Updates `.claude/pr-review-process.md` based on lessons from PR #42 (marko/vite): - Adds package-PR-specific checks (5a): module.php is optional and minimal, composer.json conventions, full new-package file structure, cross-cutting updates (issue-template dropdowns, test-count bumps, required docs page at docs/src/content/docs/packages/{name}.md) - Adds explicit "loud errors / no silent fallbacks" guidance - Adds "no defensive instanceof checks on container resolutions" - Adds "no pseudo-functionality" review item - Notes that no PR CI workflow exists; the merge-readiness signal is local lint/tests + mergeStateStatus CLEAN - Adds step 7 for drafting PR comments before posting - Reaffirms --merge (not --squash) as the merge strategy and explains Co-Authored-By trailers go on maintainer fix commits, not the merge - Expands the pre-merge checklist with package-specific items Adds a "Reviewing PRs" section to CLAUDE.md that references the doc as lookup-on-demand (not @ imported) so it loads only when relevant. Expands the .claude/ configuration list to include all existing files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes
.claude/pr-review-process.mdwith the gaps surfaced during the marko/vite review (#42) so future contributor PRs get a complete first-pass review.What's new in
.claude/pr-review-process.mdmodule.phpis optional, and minimal when used (defaults:enabled: true, list-style singletons trigger autowiring directly — explicitbindings: [X::class => X::class]entries are redundant)composer.jsonconventions:type: marko-module, noversion,self.versionfor internal deps, 4-space indentIntegrationVerificationTest/PackagingTestcount bumps)docs/src/content/docs/packages/{name}.mdperdocs/DOCS-STANDARDS.mdinstanceofchecks on container resolutionsmergeStateStatus: CLEAN)--merge, not--squash.Co-Authored-By:trailers go on maintainer fix commits, not the mergeCLAUDE.md
Adds a "Reviewing PRs" section pointing at
.claude/pr-review-process.mdas a lookup-on-demand reference (not auto-imported with@) so it doesn't consume context on non-review sessions. The.claude/configuration list now includes all the existing files in that directory.Test plan
🤖 Generated with Claude Code