fix: harden 0.7.0 release (lint config, test fixes, dep refresh)#95
Merged
Conversation
Pre-flight hardening for the 0.7.0 release. Three test failures and a broken lint config were uncovered while auditing changes since 0.6.1. - phpcs.xml: drop stale demo/app and demo/modules file entries - tests/SplitWorkflowTest: rename SPLIT_TOKEN -> MARKO_BUILD_PAT (#84) - database-mysql: hoist test helpers into Connection/Helpers.php loaded via autoload-dev.files, so factory test doesn't depend on which sibling file pest happens to load first - CHANGELOG: drop stale [Unreleased] block (release.sh regenerates) - composer: refresh lock to pick up new admin-panel-latte/twig path repos - phpcbf: auto-fix ~360 pre-existing violations across 114 files (trailing commas, multiline signatures, blank lines — cosmetic only) All 5616 tests pass; phpcs clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-flight hardening for the 0.7.0 release. Three test failures and a broken lint config were uncovered while auditing changes since 0.6.1. All fixes are mechanical and non-behavioral.
Fixes
phpcs.xml— removed staledemo/appanddemo/modulesfile entries (those directories no longer exist; lint was erroring out before scanning anything).tests/SplitWorkflowTest.php— updatedSPLIT_TOKEN→MARKO_BUILD_PATto match fix: point split workflow at MARKO_BUILD_PAT secret #84.packages/database-mysql/tests/Connection/— hoistedcreateTestDatabaseConfig()andconnectAndCapturePdoOptions()into a dedicatedHelpers.phpautoloaded viacomposer.jsonautoload-dev.files. Previously defined inline inMySqlConnectionTest.php, so they vanished whenever pest ran the factory test in isolation.composer.json— refreshed lock to sync admin-panel-latte/twig path repos and pick up develop-tracking marko/* updates. No external library version bumps (onlypredis 3.xis available and would need its own evaluation).CHANGELOG.md— removed stale[Unreleased]block (page-cache entry had already shipped in 0.6.0);release.shregenerates from gh PR data at tag time.phpcbfauto-fix — once lint was unblocked, ~360 pre-existing violations across 114 files surfaced (trailing commas, multiline method signatures, blank lines). All purely cosmetic, all tests still pass.Verification
composer test— 5616 passed, 0 failed (3 consecutive runs)vendor/bin/phpcs— cleanTest plan
composer testgreenvendor/bin/phpcsgreen🤖 Generated with Claude Code