Update composer.json to resolve dependency issue #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshust/magento2-module-pagebuildersourcecode 2.0.0 requires magento/framework ^100 -> found magento/framework[100.0.2, ..., 100.2.0-rc20]
|
Thank you @LouisdeLooze for the report. I've learned that specifying support for ALL future versions, even versions not yet released (104, 105, etc.) is a bad practice when it comes to defining Composer version constraints. So I did update this PR to use carets and |
|
@markshust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
markshust/magento2-module-pagebuildersourcecode 2.0.0 requires magento/framework ^100 -> found magento/framework[100.0.2, ..., 100.2.0-rc20] but the package is fixed to 103.0.5-p11 (lock file version) by a partial update and that version does not match.