Hotfix - Compare versions appropriately instead of string comparison#223
Merged
marksull merged 11 commits intomarksull:masterfrom Jan 30, 2026
Merged
Hotfix - Compare versions appropriately instead of string comparison#223marksull merged 11 commits intomarksull:masterfrom
marksull merged 11 commits intomarksull:masterfrom
Conversation
Selective device deployments
adding several missing possible kwargs from device record
initial support for device bgp settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All functionality is broken for FMC 10+ due to the way that FMC supported versioning is currently being compared via string comparison.
Introduced a new package: "packaging". This is to make it easy to compare string versions against each other accurately.
This resolves #222 and any other FMC 10+ deployment.
Essentially replaced every instance of:
with:
The on the fly split handles "x.x.x (build x)" as the extra build info is not needed for this comparison.