AppImage does not have libsecret

[srevinsaju]

Description

• Can you reproduce the issue?

Steps to reproduce

See: AppImage/appimage.github.io#2353

Expected behavior:

The AppImage CI should pass if all dependencies are included

CI failed: See: AppImage/appimage.github.io#2353 due to missing libsecret

Solution:

manually extract the appimage and copy libsecret from host into appimage

Versions

• Mark Text version: latest
• Operating system: ubuntu-xenial minimal

[fxha]

Thank you for reporting the issue. Mark Text requires libsecret on Linux to talk to the the system secret store and gnome-keyring or ksecretservice have to be installed on the system to do so because it's using D-Bus. I guess we don't need to builde libsecret into the AppImage because it should be a dependency of gnome-keyring and ksecretservice that provide the D-Bus service. I think it wouldn't help if we just provide the library but no service is installed on the host. Could you test this?

[srevinsaju]

@fxha Thanks for the quick reply

Yea, I guess you would have to bundle libsecret because AppImages have this principle of "working out of the box", a user should not be required to install another dependency

The test system does not have gnome-keyring. Why would marktext try to load libsecret if its not required / requested?

[fxha]

The test system does not have gnome-keyring. Why would marktext try to load libsecret if its not required / requested?

We're using keytar to securely store (access) keys and keytar depends on libsecret which depends on the OS key-chain service (currently gnome-keyring and ksecretservice). This should mean, if libsecret is missing on the host, no OS key-chain is provided. Maybe we can catch the error and provide a hint to the user to install these dependencies.

[srevinsaju]

perhaps, I am not sure.

Element, a popular Matrix client bundles libsecret, and it uses keytar too. libsecret should be copied to the appimage, because libsecret can analyze the keychain service which is available. If there is no libsecret in the first place, how can marktext communicate to gnome-keyring or ksecretservice. Am I right? so libsecret is a direct dependency of Marktext, but gnome-keyring is not a direct dependency of marktext.

Let me know if anything is missing / if you need more clarification 😄

[fxha]

I though installing the keyring also installs libsecret but it doesn't seem so. That means we have to include libsecret into the AppImage via electron-builder.