Conversation
…per reviewer feedback
Contributor
Author
|
Reviewed by: Code Reviewer Result: Approved ✅ 审核结果代码验证
变更摘要
构建日志:pnpm --filter @markus/org-manager build ✅ 成功 说明代码审核通过,等待 Owner 合并到 main 分支。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复内容
修复
packages/org-manager/src/task-service.ts中publishDeliverablestoShared()方法的两处缺陷:Defect 1 — 错误的路径变量
原代码:
!existsSync(d.reference)— 使用未解析的原始路径字符串修复:
!existsSync(src)— 使用通过 resolve() 解析的绝对路径Defect 2 — 中文文件名被错误 sanitize
原正则:
/[^a-zA-Z0-9._-]/g— 将中文字符替换为_修复:先提取 basename,再用
/[^a-zA-Z0-9_\\u4e00-\\u9fff.-]/g保留中文验证
tsc -b --noEmit通过Closes #36 (old branch with unrelated changes mixed in)