Guard against external libraries modifying Array.prototype #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi Munter! Thanks for contributing to color-diff! I'd prefer the solution using the modified loop, it should work if you change the loop to: |
1 similar comment
Munter
force-pushed
the
hasOwnProperty-fix
branch
from
6aec030 to
e0a7c2e
Compare
Contributor
Author
|
Right, I guess I was a bit tired when I tried that version. I've switched to a traditional for-loop now and the tests are passing. I've also verified that this version doesn't experience the original problem I encountered |
1 similar comment
Munter
force-pushed
the
hasOwnProperty-fix
branch
from
e0a7c2e to
467627e
Compare
Contributor
Author
|
And now with the |
markusn
added a commit
that referenced
this pull request
Feb 20, 2015
Guard against external libraries modifying Array.prototype
Owner
|
Thanks for the contribution! I will publish a new version in npm during the weekend. |
Contributor
Author
|
Thanks 👍 |
Owner
|
Tagged as 0.1.7 and published in npm. |
Contributor
Author
|
Ping @sunesimonsen |
Contributor
|
Great, thanks for the quick merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running color-diff in an environment where
Array.prototypehas been amended with helper functions, the palette will some times return color objects withNaNin every dimension.I tried using a
for(var idx1; idx1 < a.length; idx1 += 1)loop, which would be cleaner, but when I do the tests are failing.