Fix timezone handling#5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of Daylight Saving Time (DST) in the timezone encoding logic to follow the revised specification. The main change is that the encoded timezone shift should always represent the standard-time (non-DST) UTC offset, and the DST adjustment is applied autonomously by the watch based on transition dates, rather than being pre-incremented in the encoded data. The tests and documentation have been updated to reflect this change.
Specification and documentation updates:
docs/spec.mdto clarify that theShiftvalue must always be the standard-time offset, and not pre-incremented for DST. The watch now applies DST based on transition dates provided in the frame.Timezone encoding logic changes:
assembleFrameinsrc/encoder.tsto encode the base (standard-time) offset regardless of DST status, removing the previous logic that incremented the shift when DST was active.Test updates:
src/__tests__/encoder.test.tsto verify that the shift value is not modified when DST is active, and both DST and non-DST cases encode the same base shift value. [1] [2]