Allow `BooleanInput` to become a controlled input, possibly via "value" prop

[ogroppo]

Is your feature request related to a problem? Please describe.

value={true} => does not control field.value 🔴

defaultValue={true} => does not control field.value 🔴

Describe the solution you'd like

1. be able to control the filter from props
2. be able to make it like a NullableBooleanInput where developer can decide (doable with controlled input)

• false -> filter is off (undefined value)
• or true -> filter is off (undefined value)

This is extremely helpful in contexts where database does not have default value on field, so there is a mix of falsy values (null/false/'') in records (less likely on null/true, but it's possible too)

Thanks!

[djhi]

I just tested it in storybook (not published yet) and defaultValue works as expected:

If you believe there's a bug in how we handle the defaultValue, please provide a reproduction.

[ogroppo]

Hi, just pulled fresh storybook and absolutely right, the defaultValue works as expected.

However, this does not allow to make the input controllable, as per this trivial example below.

And value is not setting the checked state (the checked attribute sets the native html state, but does not set the component's state), tested on the storybook component as per screenshot

So I guess the suggestion is to enable value to set the internal field.value?

[slax57]

Hi @ogroppo ,
Thanks for your issue and PR.

I'm afraid I still don't understand why you would need to change the value of value directly.
Your initial use case (database not having default value) should be covered by defaultValue.
If it's not, can you please elaborate on why?

Your example code can't work because defaultValue is not reactive. So updating it afterwards has no effect.

To update the value of a controlled input, you should call onChange or use react-hook-form's setValue.

[ogroppo]

Thanks for getting back to me, I'll try to simplify what the use case is.
The aim is to make (in the context of List filters in particular) the BooleanInput behave like a NullableBooleanInput i.e. when false omit the value and when true let the value passthrough.

This is very useful where the data has a mix of true false and null values in the database, so false will not return the nulls. I hoped this could be achieved by not sending the parameter to the dataProvider filters when false.

I thought having the ability to control the value would do, however am having difficulties in achieving that.
Have tried format onChange and setValue but wasn't able to control both the UI and the field value so am looking for a more elegant way to do this.

Thanks!

[slax57]

@ogroppo Thanks for the additional information.
Re-reading the whole issue, I realize I've totally missed that fact that you were using this input in the context of a filter.

If that's the case, then there is probably a much easier alternative: Quick Filters.
Basically they're filters with a fixed value, which can only be on or off. So you could use a Quick Filter to only set the filter value to true, or no filter at all (when the filter is disabled).

I'll close the issue for now as I'm still not convinced a change is necessary in the RA code, but feel free to reopen if you have arguments saying otherwise.