[RFR] Improve <ReferenceInput> field#199
Merged
fzaninotto merged 12 commits intonextfrom Dec 27, 2016
Merged
Conversation
fzaninotto
changed the title
iyobo
approved these changes
Dec 25, 2016
fzaninotto
changed the title
fzaninotto
changed the title
fzaninotto
changed the title
fzaninotto
changed the title
djhi
suggested changes
Dec 27, 2016
| @@ -55,7 +55,7 @@ | |||
| "lodash.debounce": "~4.0.8", | |||
| "lodash.defaultsdeep": "^4.6.0", | |||
| * <AutocompleteInput source="author_id" options={{ fullWidth: true }} /> | ||
| */ | ||
| class AutocompleteInput extends Component { | ||
| onNewRequest = (chosenRequest, index) => { |
Contributor
There was a problem hiding this comment.
handleNewRequest ? We use onXXX for props and handleXXX for handlers everywhere I think.
| * The object passed as `options` props is passed to the material-ui <SelectField> component | ||
| */ | ||
| class SelectInput extends Component { | ||
| onChange = (event, index, value) => this.props.input.onChange(value); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<AutocompleteInput>field (Closes Autocomplete ReferenceInput #70)<ReferenceInput>(set to 25 by default)perPageprop to<ReferenceInput>to allow fetching more or less optionssortprop to<ReferenceInput>to allow sorting of optionsGET_MATCHINGREST verb (and merge withGET_LIST)optionTextaccepts a function in<SelectInput>,<RadioButtonGroupInput>, and<AutocompleteInput>optionTextaccepts an element in<SelectInput>, and<RadioButtonGroupInput>ReferenceInputvalue in filtersallowEmptyto true by default inFilterform (was breaking<ReferenceInput>in filters by default)