Tighten scope on the 'formatter' variable#100
Merged
marmelroy merged 1 commit intomarmelroy:masterfrom Jan 23, 2017
Merged
Conversation
…d the allocation during e164 formatting.
Owner
|
Thanks @sweetmandm. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
I'm doing parsing + e.164 formatting in a tight loop -- this extra allocation doesn't likely hurt a lot, but I figure why incur it if we don't have to?
What Changed?
Move the
formattervariable creation inside the scope where it is used, so it is not created if it will not be used.