Don't use possible number pattern to determine number type#36
Merged
marmelroy merged 1 commit intomarmelroy:masterfrom Mar 24, 2016
Merged
Conversation
The phone number type determination should never use the possible number pattern, since that pattern is generic and not necessarily specific to the type in question. Update `isNumberMatchingDesc` to always use the national number pattern, not the possible number pattern. Also found and fixed a bug in RegularExpressions matchesEntirely while making this change.
Owner
|
Sorry for the delay with this PR. Was travelling. Looks great. Thanks again @fikus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone number type determination should never use the possible
number pattern, since that pattern is generic and not necessarily
specific to the type in question.
Update
isNumberMatchingDescto always use the national number pattern,not the possible number pattern.
Also found and fixed a bug in RegularExpressions matchesEntirely while
making this change.