Fix PartialFormatter for regions that are not the main country#42
Merged
marmelroy merged 1 commit intomarmelroy:masterfrom Apr 8, 2016
Merged
Conversation
The metadata number formats are only specified for the country code's main country. Since PartialFormatter was using the metadata of the region code, a region that is not the code's main country would not have a format and PartialFormatter would leave the input unchanged. Fix by always using the main country for the region's country code. This matches the behavior of libphonenumber.
Owner
|
Thanks a lot @fikus. Another awesome PR! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata number formats are only specified for the country
code's main country. Since PartialFormatter was using the metadata
of the region code, a region that is not the code's main country
would not have a format and PartialFormatter would leave the input
unchanged.
Fix by always using the main country for the region's country code.
This matches the behavior of libphonenumber.