Added ability to parse phone number without throwing "unknown type" exception #81
Merged
marmelroy merged 1 commit intomarmelroy:masterfrom Nov 28, 2016
hiyainc:master
Merged
Added ability to parse phone number without throwing "unknown type" exception #81marmelroy merged 1 commit intomarmelroy:masterfrom hiyainc:master
marmelroy merged 1 commit intomarmelroy:masterfrom
hiyainc:master
Conversation
…n "unknown type"-- allows for formatting test numbers
|
This would also help cases where the metadata is not up to date for some region. Even more, probably the framework not recognizing a phone type shouldn't be an exception but just a limitation of the framework. |
Owner
|
Thanks @sorth-hiya. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows for formatting test numbers like (555) 564-8583