Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop marshmallow 3.0.0 RC releases compatibility #485

Closed
lafrech opened this issue Aug 21, 2019 · 1 comment · Fixed by #486

Comments

@lafrech
Copy link
Member

commented Aug 21, 2019

# field.container was renamed to field.inner in marshmallow 3.0.0rc8
inner_field = field.inner if hasattr(field, "inner") else field.container
ret["items"] = self.field2property(inner_field)
elif isinstance(field, marshmallow.fields.Dict):
if MARSHMALLOW_VERSION_INFO[0] >= 3:
# field.value_container was renamed to field.value_field in marshmallow 3.0.0rc8
value_field = (
field.value_field
if hasattr(field, "value_field")
else field.value_container
)

MA3 stable is out, we don't need to support older RC versions.

We could rework this in next release.

Leaving it for now to avoid unnecessary conflicts with #478.

@sloria

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Good idea; should do this on all the marshmallow libs, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.