Skip to content

Added use_instances parameter to Marshmallow plugin#144

Merged
sloria merged 2 commits intomarshmallow-code:devfrom
theirix:use_instances
Aug 16, 2017
Merged

Added use_instances parameter to Marshmallow plugin#144
sloria merged 2 commits intomarshmallow-code:devfrom
theirix:use_instances

Conversation

@theirix
Copy link
Copy Markdown
Contributor

@theirix theirix commented Aug 15, 2017

It allows to support partial Marshmallow schemas because partial fields can be specified only for Marshmallow instance.

It is not user-facing change but useful for writing plugins.

@sloria
Copy link
Copy Markdown
Member

sloria commented Aug 15, 2017

Thanks @theirix . Can you add please add yourself to AUTHORS.rst?

Once that's done this should be good to merge.

@theirix
Copy link
Copy Markdown
Contributor Author

theirix commented Aug 15, 2017

@sloria, added myself to AUTHORS. It's strange but it needs a merge.

@sloria
Copy link
Copy Markdown
Member

sloria commented Aug 15, 2017

@theirix Ah, ok. Would you mind updating this with the latest dev branch (rebase is preferred, but pull/merge is fine too).

It allows to support partial Marshmallow schemas because
partial fields can be specified only for Marshmallow instance.
@theirix
Copy link
Copy Markdown
Contributor Author

theirix commented Aug 15, 2017

Done, rebased.

@sloria
Copy link
Copy Markdown
Member

sloria commented Aug 15, 2017

Excellent. I will merge and release this when I get home today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants