Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added use_instances parameter to Marshmallow plugin #144

Merged
merged 2 commits into from Aug 16, 2017

Conversation

@theirix
Copy link
Contributor

commented Aug 15, 2017

It allows to support partial Marshmallow schemas because partial fields can be specified only for Marshmallow instance.

It is not user-facing change but useful for writing plugins.

@sloria

This comment has been minimized.

Copy link
Member

commented Aug 15, 2017

Thanks @theirix . Can you add please add yourself to AUTHORS.rst?

Once that's done this should be good to merge.

@theirix

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2017

@sloria, added myself to AUTHORS. It's strange but it needs a merge.

@sloria

This comment has been minimized.

Copy link
Member

commented Aug 15, 2017

@theirix Ah, ok. Would you mind updating this with the latest dev branch (rebase is preferred, but pull/merge is fine too).

theirix added some commits Aug 15, 2017

Added use_instances parameter to Marshmallow plugin
It allows to support partial Marshmallow schemas because
partial fields can be specified only for Marshmallow instance.

@theirix theirix force-pushed the theirix:use_instances branch from 79d7a6a to 24d1940 Aug 15, 2017

@theirix

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2017

Done, rebased.

@sloria

This comment has been minimized.

Copy link
Member

commented Aug 15, 2017

Excellent. I will merge and release this when I get home today.

@sloria sloria merged commit b98fadc into marshmallow-code:dev Aug 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.