Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't let Path inherit from dict #190
While investigating #189, I've been wondering why
It looks like most content is duplicated in
This PR removes this inheritance to simplify the code. It makes more sense to me this way. It brings no enhancement, but tries to improve maintainability.
What was the reason for the original design? Any objection to this simplification?
I had to modify 2 tests to get this going. This could mean I'm totally mistaken, but from the name of the tests, I don't think the behaviour I modified is what was being tested, rather a side-effect.
Note that if this PR is applied, we'll probably need to change
to get the behaviour proposed in #189.