Call resolve_schema_cls throught OpenAPIConverter#346
Merged
sloria merged 1 commit intomarshmallow-code:devfrom Dec 16, 2018
Merged
Call resolve_schema_cls throught OpenAPIConverter#346sloria merged 1 commit intomarshmallow-code:devfrom
sloria merged 1 commit intomarshmallow-code:devfrom
Conversation
Member
|
Seems like a fine change. Thanks! |
Contributor
Author
|
Thank's ! |
Contributor
Author
|
@sloria Do you know when is planned next pypi release (with with merge) ? |
Member
|
This is released in 1.0.0b6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
We start writing apispec plugins and this change could be appreciated: You can see in following methods:
apispec.ext.marshmallow.MarshmallowPlugin#inspect_schema_for_auto_referencingapispec.ext.marshmallow.openapi.OpenAPIConverter#resolve_schema_dictresolve_schema_clsis directly called. In our plugins, we want override this method. For now, we have to completely override these method:With these changes, we will be able to override only the concerned part:
Thank's,
bux.