Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call resolve_schema_cls throught OpenAPIConverter #346

Merged
merged 1 commit into from Dec 16, 2018

Conversation

@buxx
Copy link
Contributor

commented Nov 29, 2018

Hello,

We start writing apispec plugins and this change could be appreciated: You can see in following methods:

  • apispec.ext.marshmallow.MarshmallowPlugin#inspect_schema_for_auto_referencing
  • apispec.ext.marshmallow.openapi.OpenAPIConverter#resolve_schema_dict

resolve_schema_cls is directly called. In our plugins, we want override this method. For now, we have to completely override these method:

With these changes, we will be able to override only the concerned part:

Thank's,
bux.

@sloria

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

Seems like a fine change. Thanks!

@sloria sloria merged commit d94ff4b into marshmallow-code:dev Dec 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@buxx

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2018

Thank's !

@buxx buxx deleted the algoo:override-friendly branch Dec 17, 2018

@buxx

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2018

@sloria Do you know when is planned next pypi release (with with merge) ?

@sloria

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

This is released in 1.0.0b6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.