Skip to content

Call resolve_schema_cls throught OpenAPIConverter#346

Merged
sloria merged 1 commit intomarshmallow-code:devfrom
algoo:override-friendly
Dec 16, 2018
Merged

Call resolve_schema_cls throught OpenAPIConverter#346
sloria merged 1 commit intomarshmallow-code:devfrom
algoo:override-friendly

Conversation

@buxx
Copy link
Copy Markdown
Contributor

@buxx buxx commented Nov 29, 2018

Hello,

We start writing apispec plugins and this change could be appreciated: You can see in following methods:

  • apispec.ext.marshmallow.MarshmallowPlugin#inspect_schema_for_auto_referencing
  • apispec.ext.marshmallow.openapi.OpenAPIConverter#resolve_schema_dict

resolve_schema_cls is directly called. In our plugins, we want override this method. For now, we have to completely override these method:

With these changes, we will be able to override only the concerned part:

Thank's,
bux.

@sloria
Copy link
Copy Markdown
Member

sloria commented Dec 16, 2018

Seems like a fine change. Thanks!

@sloria sloria merged commit d94ff4b into marshmallow-code:dev Dec 16, 2018
@buxx
Copy link
Copy Markdown
Contributor Author

buxx commented Dec 17, 2018

Thank's !

@buxx buxx deleted the override-friendly branch December 17, 2018 15:21
@buxx
Copy link
Copy Markdown
Contributor Author

buxx commented Dec 17, 2018

@sloria Do you know when is planned next pypi release (with with merge) ?

@sloria
Copy link
Copy Markdown
Member

sloria commented Dec 18, 2018

This is released in 1.0.0b6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants